Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add new externs for file append and cpu time #1126

Merged
merged 11 commits into from
Dec 16, 2024

Conversation

ajewellamz
Copy link
Contributor

Issue #, if available:

Description of changes:

Squash/merge commit message, if applicable:

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@ajewellamz ajewellamz requested a review from a team as a code owner December 15, 2024 16:51
Copy link
Contributor

@lucasmcdonald3 lucasmcdonald3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Python externs LGTM.

StandardLibrary/src/Time.dfy Outdated Show resolved Hide resolved
StandardLibrary/test/TestString.dfy Show resolved Hide resolved
lucasmcdonald3
lucasmcdonald3 previously approved these changes Dec 16, 2024
Copy link
Contributor

@RitvikKapila RitvikKapila left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a few comments. Apart from this, Rust externs look good to me.

Copy link
Contributor

@RitvikKapila RitvikKapila left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for making the updates. LGTM.

@ajewellamz ajewellamz merged commit 382edfd into main Dec 16, 2024
143 checks passed
@ajewellamz ajewellamz deleted the ajewell/new-externs branch December 16, 2024 23:03
Copy link
Contributor

@ShubhamChaturvedi7 ShubhamChaturvedi7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left some comments on the Go externs.


func GetProcessCpuTimeMillis() int64 {
usage := new(syscall.Rusage)
syscall.Getrusage(syscall.RUSAGE_SELF, usage)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The doc says this can return an error, and next line then can cause panic.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants