-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: add new externs for file append and cpu time #1126
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Python externs LGTM.
Co-authored-by: Lucas McDonald <[email protected]>
StandardLibrary/runtimes/go/ImplementationFromDafny-go/Time_/externs.go
Outdated
Show resolved
Hide resolved
StandardLibrary/runtimes/go/ImplementationFromDafny-go/FileIO/externs.go
Show resolved
Hide resolved
…xterns.go Co-authored-by: Lucas McDonald <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left a few comments. Apart from this, Rust externs look good to me.
AwsCryptographicMaterialProviders/runtimes/rust/src/dafny_libraries.rs
Outdated
Show resolved
Hide resolved
AwsCryptographicMaterialProviders/runtimes/rust/src/dafny_libraries.rs
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for making the updates. LGTM.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left some comments on the Go externs.
StandardLibrary/runtimes/go/ImplementationFromDafny-go/FileIO/externs.go
Show resolved
Hide resolved
StandardLibrary/runtimes/go/ImplementationFromDafny-go/FileIO/externs.go
Show resolved
Hide resolved
|
||
func GetProcessCpuTimeMillis() int64 { | ||
usage := new(syscall.Rusage) | ||
syscall.Getrusage(syscall.RUSAGE_SELF, usage) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The doc says this can return an error, and next line then can cause panic.
Issue #, if available:
Description of changes:
Squash/merge commit message, if applicable:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.